This repository has been archived by the owner on Jun 18, 2024. It is now read-only.
scx: Improve error reporting after an early scx_bpf_error() #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If scx_bpf_error() is triggered while a BPF scheduler is being loaded, depending on the point of failure, it can make ops_state transition fail and thus make loading fail with -EBUSY, which isn't very descriptive. There was already a workaround for a specific case where ops.init() triggers scx_bpf_error() which works by just reporting success so that the usual exit path report the error with all the details. There's no reason to restrict this to ops.init() failure. These early scx_bpf_error()s always make the ops_state transitions fail and we can always finish loading with success and let the exit path report the faliure.
jordalgo
reviewed
Feb 28, 2024
Byte-Lab
reviewed
Feb 28, 2024
Byte-Lab
approved these changes
Feb 28, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If scx_bpf_error() is triggered while a BPF scheduler is being loaded, depending on the point of failure, it can make ops_state transition fail and thus make loading fail with -EBUSY, which isn't very descriptive.
There was already a workaround for a specific case where ops.init() triggers scx_bpf_error() which works by just reporting success so that the usual exit path report the error with all the details.
There's no reason to restrict this to ops.init() failure. These early scx_bpf_error()s always make the ops_state transitions fail and we can always finish loading with success and let the exit path report the faliure.