This repository has been archived by the owner on Jun 18, 2024. It is now read-only.
scx: Fix CPU online tracking #215
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 10d167d ("SCX: Synchronize boot CPU's online state with SCX_RQ_ONLINE") fixes the oversight that we're not synchronizing the boot CPU's online state with scx_rq's online state. It does this by adding a check in init_sched_ext_class() for whether a CPU is online, and setting the SCX_RQ_ONLINE flag in the rq if it is. The online mask may not be initialized by the time init_sched_ext_class() is invoked, so let's add a late init function where we iterate over the possible CPUs and do this check there. Signed-off-by: David Vernet <void@manifault.com>
|
Can confirm, this patch fixes the sched-ext regression. Tested-by: Peter Jung ptr1337@cachyos.org |
|
Tested-by: Piotr Gorski piotrgorski@cachyos.org |
|
Hmm, multiple CachyOS users (using x86) are swearing that this PR improves interactivity over @htejun's original fix. I'm confused as to why, as it should have been a no-op. Will have to look more closely next week. |
|
I'm going to close this out -- there really shouldn't be any difference between top of tree and this fix. If someone is able to show something statistically significant we can reopen and revisit. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 10d167d ("SCX: Synchronize boot CPU's online state with SCX_RQ_ONLINE") fixes the oversight that we're not synchronizing the boot CPU's online state with scx_rq's online state. It does this by adding a check in init_sched_ext_class() for whether a CPU is online, and setting the SCX_RQ_ONLINE flag in the rq if it is.
The online mask may not be initialized by the time init_sched_ext_class() is invoked, so let's add a late init function where we iterate over the possible CPUs and do this check there.