-
Notifications
You must be signed in to change notification settings - Fork 29
scx: Add maintainer and maintainer url to struct_ops #227
Conversation
@htejun this can probably wait until after the merge, just a thought I had to help improve support. Let me know what you think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's a great idea to have a designated place to report the official maintainer(s) for each scheduler. However, I'm concerned that this might encourage people to contact individuals directly, instead of opening issues on the github page.
For the sched_ext kernel patch itself, reaching out to the maintainers directly makes sense, because it's the "regular upstream kernel" workflow. But for the schedulers, if we want to continue using github, perhaps we should also include a message encouraging people to open an issue here in case of errors. WDYT?
I think it would make sense to do something similar but also in scx-scheds. For example, at this point:
Information about sched-ext in such a place would also be useful. As @arighi pointed out, it would be good to encourage users to report bugs on github, as direct contact with the maintainer of a given scheduler would deprive most users of insight into the current situation and the ability to see if the bug they are facing is also happening to other users |
Yeah, I think that is a valid concern. I think that's why I didn't want to do a check/validation on maintainer existing when the scheduler is loaded. I guess a maintainer URL is flexible enough you could do the assignment with something like:
I think that makes sense, I can make that message a little more clear on this URL should be used for support. I think one of the concerns was that anyone can create whatever scheduler they want and the kernel has no way knowing where support should be directed, whether that is an individual or a Github repo. Maybe the best solution is having at least one different contact field required? |
I've also though that maybe this should be a first class thing for |
56d4c8a
to
f84b742
Compare
If the loaded BPF scheduler encounters an error finding the appropriate support will be challenging. Add fields to the struct_ops for sched_ext to include a scheduler maintainer and an optional support url. Signed-off-by: Daniel Hodges <hodges.daniel.scott@gmail.com>
Hmm, so, this seems like something that schedulers should be able to report from user space, or they can use the |
I think it'd be useful to have some way to trace where the scheduler came from but I'm not sure including maintainer string is the right way. I wonder whether it'd be more useful / generic to be able to point back to the binary which loaded the scheduler. Then, the user or admin would be able to trace back using the usual mechanisms (e.g. querying package manager, checking versions and sha1 and so on). Also, this feels more like a generic BPF thing. |
If the loaded BPF scheduler encounters an error finding the appropriate support will be challenging. Add fields to the struct_ops for sched_ext to include a scheduler maintainer and an optional support url.