Skip to content

Commit

Permalink
drm/i915/panelreplay: Move out psr_init_dpcd() from init_connector()
Browse files Browse the repository at this point in the history
Move psr_init_dpcd() from init-connector to connector-detect
function. The dpcd probe for checking panel replay capability
for external dp connector is causing delay during boot which can
be optimized by moving dpcd probe to connector specific detect().

v1: Initial version.
v2: Add details in commit description. [Jani]

Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/10284
Signed-off-by: Animesh Manna <animesh.manna@intel.com>
Fixes: cceeaa3 ("drm/i915/panelreplay: Enable panel replay dpcd initialization for DP")
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240229043716.4065760-1-animesh.manna@intel.com
  • Loading branch information
animesh-manna committed Mar 1, 2024
1 parent 12531c8 commit 1cca19b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
3 changes: 3 additions & 0 deletions drivers/gpu/drm/i915/display/intel_dp.c
Original file line number Diff line number Diff line change
Expand Up @@ -5777,6 +5777,9 @@ intel_dp_detect(struct drm_connector *connector,
if (ret == 1)
intel_connector->base.epoch_counter++;

if (!intel_dp_is_edp(intel_dp))
intel_psr_init_dpcd(intel_dp);

intel_dp_detect_dsc_caps(intel_dp, intel_connector);

intel_dp_configure_mst(intel_dp);
Expand Down
3 changes: 0 additions & 3 deletions drivers/gpu/drm/i915/display/intel_psr.c
Original file line number Diff line number Diff line change
Expand Up @@ -2883,9 +2883,6 @@ void intel_psr_init(struct intel_dp *intel_dp)
if (!(HAS_PSR(dev_priv) || HAS_DP20(dev_priv)))
return;

if (!intel_dp_is_edp(intel_dp))
intel_psr_init_dpcd(intel_dp);

/*
* HSW spec explicitly says PSR is tied to port A.
* BDW+ platforms have a instance of PSR registers per transcoder but
Expand Down

0 comments on commit 1cca19b

Please sign in to comment.