add option to change debug/log level per invocation #61
Conversation
src/rt-app_args.c
Outdated
| @@ -42,6 +43,7 @@ char help_full[] = \ | |||
| "through the standard input.\n\n" | |||
| "Miscellaneous:\n" | |||
| " -v, --version display version information and exit\n" | |||
| " -l, --log set log level (0...100 recommended, 50 default)\n" | |||
There was a problem hiding this comment.
because other values don't make sense. actually, the lowest value that makes sense is 10 (ERROR and CRITICAL), the highest is 100.
i was trying to keep within the string length, but could elaborate, if you like...
There was a problem hiding this comment.
Ah OK sorry.. I misinterpreted as if 100 was the recommended value.
Maybe we could just remove "recommended" and check that user don't pick something outside the range?
|
Apart from the nitpick, thanks for this LGTM. @vingu-linaro ? would be nice to be able to write |
|
i agree with the point about meaningful values. that should be done properly (with an array of LOG_LEVELs and their associated strings), though. would it be ok if i just state the levels explicitly in the help text, in the meantime? |
Sure. Please add INFO and NOTICE in the help text above. |
|
done that... |
Signed-off-by: Volker Eckert <volker.eckert@arm.com>
|
It looks now good to me! Thanks! |
|
LGTM too. |
proposed implementation of #59