permit strings as log level parameters #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }; | ||
|
|
||
| struct loglevel lls[] = { LLS }; | ||
| #undef C |
There was a problem hiding this comment.
I still don't like this undef then re-def. This is quite confusing and over complexify the code for no good reason. Furthermore, the "levels" are defined at 2 different places so you can't easily know what is it.
Gather everything related to level in one place and don't use undef
There was a problem hiding this comment.
i don't understand what you mean by that the levels are defined in 2 different places? clearly this is exactly the advantage of the above approach that you don't have to maintain 2 separate definitions, no? how would you do that without re-using one macro, i wonder...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.