Skip to content

Commit

Permalink
[Telemetry] Move storage, octane, oort, service_worker, and speedomet…
Browse files Browse the repository at this point in the history
…er benchmarks to story expectations.

TBR=charliea@chromium.org

Bug: 713222
Change-Id: I76408d010947de7c14ec8959044f5f76daca10dc
Reviewed-on: https://chromium-review.googlesource.com/540702
Reviewed-by: rnephew <rnephew@chromium.org>
Commit-Queue: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480759}
  • Loading branch information
randalnephew authored and Commit Bot committed Jun 20, 2017
1 parent 6689443 commit 88efc12
Show file tree
Hide file tree
Showing 9 changed files with 52 additions and 0 deletions.
6 changes: 6 additions & 0 deletions tools/perf/benchmarks/indexeddb_perf.py
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,9 @@ class IndexedDbOriginalSectioned(perf_benchmark.PerfBenchmark):
def Name(cls):
return 'storage.indexeddb_endure'

def GetExpectations(self):
return page_sets.IndexedDBEndureStoryExpectations()


@benchmark.Disabled('linux') # crbug.com/677972
@benchmark.Owner(emails=['cmumford@chromium.org'])
Expand All @@ -121,3 +124,6 @@ def Name(cls):
@classmethod
def ValueCanBeAddedPredicate(cls, value, is_first_result):
return 'idb' in value.name

def GetExpectations(self):
return page_sets.IndexedDBEndureStoryExpectations()
6 changes: 6 additions & 0 deletions tools/perf/benchmarks/octane.py
Original file line number Diff line number Diff line change
Expand Up @@ -154,3 +154,9 @@ def CreateStorySet(self, options):
ps, ps.base_dir, make_javascript_deterministic=False,
name='http://chromium.github.io/octane/index.html?auto=1'))
return ps

def GetExpectations(self):
class StoryExpectations(story.expectations.StoryExpectations):
def SetExpectations(self):
pass # Octane not disabled.
return StoryExpectations()
12 changes: 12 additions & 0 deletions tools/perf/benchmarks/oortonline.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

from core import perf_benchmark
from telemetry import benchmark
from telemetry import story
from telemetry.page import legacy_page_test
from telemetry.value import scalar
from telemetry.value import improvement_direction
Expand Down Expand Up @@ -49,6 +50,11 @@ def Name(cls):
def CreateStorySet(self, options):
return page_sets.OortOnlinePageSet()

def GetExpectations(self):
class StoryExpectations(story.expectations.StoryExpectations):
def SetExpectations(self):
pass # http://oortonline.gl/#run not disabled.
return StoryExpectations()

# Disabled on Linux due to timeouts; crbug.com/727850
@benchmark.Disabled('linux', 'win')
Expand All @@ -67,6 +73,12 @@ class OortOnlineTBMv2(perf_benchmark.PerfBenchmark):

page_set = page_sets.OortOnlineTBMPageSet

def GetExpectations(self):
class StoryExpectations(story.expectations.StoryExpectations):
def SetExpectations(self):
pass # http://oortonline.gl/#run not disabled.
return StoryExpectations()

def CreateTimelineBasedMeasurementOptions(self):
categories = [
# Implicitly disable all categories.
Expand Down
6 changes: 6 additions & 0 deletions tools/perf/benchmarks/service_worker.py
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,9 @@ class ServiceWorkerPerfTest(perf_benchmark.PerfBenchmark):
def Name(cls):
return 'service_worker.service_worker'

def GetExpectations(self):
return page_sets.ServiceWorkerStoryExpectations()


@benchmark.Disabled('android-webview') # http://crbug.com/653924
@benchmark.Owner(emails=['horo@chromium.org'])
Expand All @@ -195,3 +198,6 @@ def Name(cls):
def ShouldDisable(cls, possible_browser): # http://crbug.com/597656
return (possible_browser.browser_type == 'reference' and
possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X')

def GetExpectations(self):
return page_sets.ServiceWorkerMicroBenchmarksStoryExpectations()
6 changes: 6 additions & 0 deletions tools/perf/benchmarks/speedometer.py
Original file line number Diff line number Diff line change
Expand Up @@ -107,3 +107,9 @@ def CreateStorySet(self, options):
make_javascript_deterministic=False,
name='http://browserbench.org/Speedometer/'))
return ps

def GetExpectations(self):
class StoryExpectations(story.expectations.StoryExpectations):
def SetExpectations(self):
pass # http://browserbench.org/Speedometer/ not disabled.
return StoryExpectations()
5 changes: 5 additions & 0 deletions tools/perf/page_sets/indexeddb_endure_page.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,3 +45,8 @@ def __init__(self):
]
for test in tests:
self.AddStory(IndexedDBEndurePage(test, self))


class IndexedDBEndureStoryExpectations(story.expectations.StoryExpectations):
def SetExpectations(self):
pass # Nothing disabled.
1 change: 1 addition & 0 deletions tools/perf/page_sets/oortonline.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ def RunPageInteractions(self, action_runner):
with action_runner.CreateInteraction('End'):
action_runner.tab.browser.DumpMemory()


class OortOnlineTBMPageSet(story.StorySet):
"""Oort Online WebGL benchmark for TBM.
URL: http://oortonline.gl/#run
Expand Down
5 changes: 5 additions & 0 deletions tools/perf/page_sets/service_worker.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,3 +40,8 @@ def __init__(self):
self.AddStory(page.Page(
'https://jakearchibald.github.io/svgomg/', self,
name='svgomg_second_load', make_javascript_deterministic=False))


class ServiceWorkerStoryExpectations(story.expectations.StoryExpectations):
def SetExpectations(self):
pass # Nothing disabled.
5 changes: 5 additions & 0 deletions tools/perf/page_sets/service_worker_micro_benchmark.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,3 +33,8 @@ def __init__(self):
'http://localhost:8091/index.html', self,
make_javascript_deterministic=False,
name='http://localhost:8091/index.html'))

class ServiceWorkerMicroBenchmarksStoryExpectations(
story.expectations.StoryExpectations):
def SetExpectations(self):
pass # Nothing disabled.

0 comments on commit 88efc12

Please sign in to comment.