Support MIDI CC 64 Sustain. #88
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would just like to say thanks for this patch! After play with some MIDI files collection of my own, it works quite good and perfectly addressed the CC64 issue mentioned in #86. It would be even better if this change could be merged. Anyway, thanks again! |
|
@BLumia Glad it works! Thanks for the test. If you have a project that uses TinySoundFont and you need the change before it's officially merged, you can point the project to the repo |
nwhitehead
force-pushed
the
sustain
branch
2 times, most recently
from
3304b7f to
e520bdc
Compare
|
hi @schellingb , do you have any concerns on this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for MIDI CC 64, sustain pedal.
This is a commonly used MIDI CC message and not too much work to support at the channel level in TinySoundFont. It requires adding a bit of state to every playing voice to remember which voices are playing because sustain is on. Every channel also gets a field to record whether sustain is on or off.