validator: added support for autocasting from a string #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanJakes
reviewed
Apr 18, 2017
src/Validator.php
Outdated
| } | ||
| } elseif ($type === 'int') { | ||
| if (is_int($node)) { | ||
| $isValid = $this->validateNumber($node, $schema, $path, $errors); | ||
| break; | ||
| } elseif ($autoCast && is_string($node) && preg_match('#^-?[1-9][0-9]*+\z#', $node) === 1) { |
There was a problem hiding this comment.
This wouldn't accept 0, right? There is also filter_var... maybe?
src/Validator.php
Outdated
| } | ||
| } elseif ($type === 'float') { | ||
| if (is_float($node)) { | ||
| $isValid = $this->validateNumber($node, $schema, $path, $errors); | ||
| break; | ||
| } elseif ($autoCast && is_string($node) && preg_match('#^-?[1-9][0-9]*+(\.[0-9]+)?\z#', $node) === 1) { |
There was a problem hiding this comment.
This also wouldn't accept 0 and there are also other float notations (1e12, etc.), but I'm not sure if we want to support those. Here is_numeric() would probably do the job.
| $errors = []; | ||
| $stack = [[$this->schema, $data, '/']]; | ||
| while (list ($schema, $node, $path) = array_pop($stack)) { | ||
| $stack = [[$this->schema, & $outData, '/']]; |
There was a problem hiding this comment.
Why so many &? It's kind of hard to read.
JanTvrdik
reviewed
Apr 18, 2017
src/Validator.php
Outdated
| @@ -29,11 +29,16 @@ public function __construct(array $schema, bool $failFast = false, callable $ref | |||
| } | |||
|
|
|||
|
|
|||
| public function validate($data): Result | |||
| public function validate($data, bool $autoCast = false): Result | |||
There was a problem hiding this comment.
btw: this is often called coercion, e.g. https://github.com/justinrainbow/json-schema#type-coercion
|
Guys, thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.