Change isReviewed -> isApproved (#11)

schlagelk · Oct 29, 2021 · 5e36e2b · 5e36e2b
1 parent 751a9b1
commit 5e36e2b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/Sources/mariachiLib/GitHub/GitHubModels.swift b/Sources/mariachiLib/GitHub/GitHubModels.swift
@@ -79,7 +79,7 @@ public class Review: Decodable {
       state
   }
 
-  var isReviewed: Bool {
+  var isApproved: Bool {
       reviewState == "APPROVED"
   }
 }
@@ -100,7 +100,7 @@ public extension Array where Element: PullRequest {
   func needing(minApprovals: Int) -> [PullRequest] {
       var needingApprovalsTemp = [PullRequest]()
       for pull in self {
-        let validReviews = pull.reviews?.filter { $0.isReviewed }.uniquingReviewers.count ?? 0
+        let validReviews = pull.reviews?.filter { $0.isApproved }.uniquingReviewers.count ?? 0
           if validReviews < minApprovals {
               needingApprovalsTemp.append(pull)
           }

diff --git a/Tests/mariachiUnitTests/MariachiUnitTests.swift b/Tests/mariachiUnitTests/MariachiUnitTests.swift
@@ -34,9 +34,9 @@ final class MariachiUnitTests: XCTestCase {
     let reviewData = try JSONSerialization.data(withJSONObject: reviewsData, options: [])
     let reviews = try JSONDecoder().decode([Review].self, from: reviewData)
 
-    XCTAssertTrue(reviews[0].isReviewed)
-    XCTAssertTrue(reviews[1].isReviewed)
-    XCTAssertFalse(reviews[2].isReviewed)
+    XCTAssertTrue(reviews[0].isApproved)
+    XCTAssertFalse(reviews[1].isApproved)
+    XCTAssertFalse(reviews[2].isApproved)
   }
 
   func testUniquingUsers() throws {