Added support to extract translations from form constraints #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goetas
reviewed
Aug 7, 2020
| @@ -43,6 +44,9 @@ public function buildForm(FormBuilderInterface $builder, array $options) | |||
| ->add('street', 'text', [ | |||
| 'label' => /** @Desc("Street") */ 'form.label.street', | |||
| 'translation_domain' => 'address', | |||
| 'constraints' => [ | |||
| new NotBlank(['message' => /** @Desc("You should fill in the street") */ 'form.street.empty_value']), | |||
There was a problem hiding this comment.
Can you explain what is this @Desc("You should fill in the street") comment?
There was a problem hiding this comment.
Hi @goetas. @Desc adds a default text into the translation file, and I,ve added it to test if it works as for the other options of the form (choices, etc)
The feature is tested, please check the FormExtractor tests.
There was a problem hiding this comment.
@goetas Is there anything else I should do on the PR?
|
thanks ! |
👍 Thank you too! |
|
@goetas Can you also create a release, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added extraction from form
constraintsnode.Todos