Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support symfony 7 #595

Merged
merged 2 commits into from
Feb 7, 2025
Merged

Support symfony 7 #595

merged 2 commits into from
Feb 7, 2025

Conversation

deguif
Copy link
Contributor

@deguif deguif commented Jan 14, 2025

Q A
Bug fix? yes/no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes/no
Fixed tickets
License Apache2

@goetas
Copy link
Collaborator

goetas commented Jan 22, 2025

could you have a look at the failing test?

@deguif
Copy link
Contributor Author

deguif commented Jan 22, 2025

Yes, I had a look. This won't be that easy to support and will probably need a new major version as sensio/framework-extra-bundle package should be dropped.

@goetas
Copy link
Collaborator

goetas commented Jan 22, 2025

dropping sensio/framework-extra-bundle is not a problem, and if the user does not need to change their code, no major version is required

@deguif
Copy link
Contributor Author

deguif commented Jan 28, 2025

@goetas I think major version is needed, as the annotations from the sensio/framework-extra-bundle package are used in the project. I previously added a way to use this bundle without the sensio/framework-extra-bundle but some users can rely on this behaviour.
See #569 for the fallback

@goetas
Copy link
Collaborator

goetas commented Feb 1, 2025

@deguif thanks a lot for your work! could you please rebase the various PR you have in progress?

@deguif
Copy link
Contributor Author

deguif commented Feb 3, 2025

@deguif thanks a lot for your work! could you please rebase the various PR you have in progress?

I just rebased my opened PRs.

Thanks a lot for merging quickly the previous PRs ;)

@deguif deguif force-pushed the symfony-7 branch 16 times, most recently from 1607622 to 9343b22 Compare February 3, 2025 19:36
@deguif
Copy link
Contributor Author

deguif commented Feb 3, 2025

All tests with composer dependencies set to lowest are passing (including with Symfony 7.x), but there is an issue with symfony/phpunit-bridge for the other run with highest dependencies.

For symfony 7.x I had to:

  • remove sensio/framework-extra-bundle in a github action step
  • disable the annotations in framework config
  • enable the http_method_override in framework config

@deguif deguif force-pushed the symfony-7 branch 7 times, most recently from 913c54a to 2f7c751 Compare February 4, 2025 12:08
@deguif deguif force-pushed the symfony-7 branch 13 times, most recently from aa581d1 to 4d25baf Compare February 4, 2025 13:00
@deguif
Copy link
Contributor Author

deguif commented Feb 4, 2025

Tests are now green.

@deguif
Copy link
Contributor Author

deguif commented Feb 5, 2025

I rebased it too. It's ready for review and merge.

@sabin-petru
Copy link

Hello, any eta for merging this?

@goetas goetas merged commit a9963ff into schmittjoh:master Feb 7, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants