Only add the YamlDriver to the chain when symfony/yaml is installed
#1497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scyzoryck
reviewed
Jun 28, 2023
mbabker
force-pushed
the
check-yaml-availability
branch
from
bcc111a
to
d0faf99
Compare
scyzoryck
approved these changes
Jun 29, 2023
goetas
reviewed
Jul 31, 2023
goetas
reviewed
Jul 31, 2023
mbabker
force-pushed
the
check-yaml-availability
branch
from
d0faf99
to
7e82eb7
Compare
mbabker
force-pushed
the
check-yaml-availability
branch
from
7e82eb7
to
7befd1d
Compare
This was referenced Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
JMS\Serializer\Metadata\Driver\YamlDriverclass requiresSymfony\Component\Yaml\Yamlto function. Givensymfony/yamlis an optional dependency, it shouldn't be arbitrarily included in the driver chain when using the default driver factory and specifying a list of metadata paths. This PR updates the factory to check for theYamlclass before adding the YAML driver to the chain.