Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Symfony 7 in dev dependencies #1514

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Allow Symfony 7 in dev dependencies #1514

merged 1 commit into from
Sep 18, 2023

Conversation

mbabker
Copy link
Contributor

@mbabker mbabker commented Sep 18, 2023

Q A
Bug fix? no
New feature? yes
Doc updated no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets N/A
License MIT

Adds Symfony 7 to the version ranges for the dev dependencies.

Locally, with the "minimum-stability": "dev" flag added in composer.json, it updates most components to the 7.0 branch and all tests pass.

Updated Composer Packages 
$ composer update
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 86 updates, 0 removals
  - Upgrading doctrine/annotations (2.0.1 => 2.0.x-dev 94f40ad)
  - Upgrading doctrine/cache (2.2.0 => 2.2.x-dev 256cc58)
  - Upgrading doctrine/coding-standard (12.0.0 => 12.0.x-dev 3e88327)
  - Upgrading doctrine/collections (1.8.0 => 1.8.x-dev ca783dc)
  - Upgrading doctrine/common (3.4.3 => 3.5.x-dev c1e3356)
  - Upgrading doctrine/data-fixtures (1.6.7 => 1.7.x-dev 621898f)
  - Upgrading doctrine/dbal (3.6.6 => 3.7.x-dev f29467a)
  - Upgrading doctrine/deprecations (v1.1.1 => 1.1.x-dev bdaa697)
  - Upgrading doctrine/event-manager (2.0.0 => 2.0.x-dev 12f08bd)
  - Upgrading doctrine/inflector (2.0.8 => 2.1.x-dev d62dadc)
  - Upgrading doctrine/instantiator (1.5.0 => 2.0.x-dev f49f6a8)
  - Upgrading doctrine/lexer (2.1.0 => 2.1.x-dev e74756f)
  - Upgrading doctrine/orm (2.16.2 => 2.17.x-dev a2d2e17)
  - Upgrading doctrine/persistence (2.5.7 => 2.5.x-dev e36f227)
  - Upgrading doctrine/phpcr-odm (1.7.1 => 2.x-dev f0640a0)
  - Upgrading jackalope/jackalope (1.4.6 => 1.x-dev 6418f6b)
  - Upgrading jackalope/jackalope-doctrine-dbal (1.9.0 => 1.x-dev 3af9844)
  - Upgrading jms/metadata (2.8.0 => dev-master 1e72a14)
  - Upgrading myclabs/deep-copy (1.11.1 => 1.x-dev f6f48cf)
  - Upgrading nikic/php-parser (v4.17.1 => 4.x-dev a6303e5)
  - Upgrading phar-io/manifest (2.0.3 => dev-master 6772927)
  - Upgrading phpbench/container (2.2.1 => dev-master 6d555ff)
  - Upgrading phpbench/phpbench (1.2.14 => dev-master 6d269eb)
  - Upgrading phpcr/phpcr (2.1.8 => 2.1.x-dev ecaf56d)
  - Upgrading phpcr/phpcr-utils (1.8.0 => 1.x-dev 50e99c9)
  - Upgrading phpstan/phpstan (1.10.34 => 1.11.x-dev 4caad03)
  - Upgrading phpunit/php-code-coverage (10.1.5 => dev-main f653208)
  - Upgrading phpunit/php-invoker (4.0.0 => dev-main 8a4ed1c)
  - Upgrading phpunit/php-text-template (3.0.1 => dev-main 195a92b)
  - Upgrading phpunit/php-timer (6.0.0 => dev-main c8611db)
  - Upgrading phpunit/phpunit (10.3.4 => dev-main 6f7f70c)
  - Upgrading psr/cache (3.0.0 => dev-master 0a7c67d)
  - Upgrading psr/container (2.0.2 => dev-master 90db7b9)
  - Upgrading psr/event-dispatcher (1.0.0 => dev-master e275e2d)
  - Upgrading psr/log (3.0.0 => dev-master fe5ea30)
  - Upgrading sebastian/cli-parser (2.0.0 => dev-main 2250dc6)
  - Upgrading sebastian/code-unit (2.0.0 => dev-main 687bbc6)
  - Upgrading sebastian/code-unit-reverse-lookup (3.0.0 => dev-main 6cdf489)
  - Upgrading sebastian/comparator (5.0.1 => dev-main 548ca65)
  - Upgrading sebastian/complexity (3.0.1 => dev-main d1e53a3)
  - Upgrading sebastian/diff (5.0.3 => dev-main 5982dfa)
  - Upgrading sebastian/environment (6.0.1 => dev-main e861506)
  - Upgrading sebastian/exporter (5.1.0 => dev-main 326ce39)
  - Upgrading sebastian/global-state (6.0.1 => dev-main a0a8276)
  - Upgrading sebastian/lines-of-code (2.0.1 => dev-main 9f7eb6c)
  - Upgrading sebastian/object-enumerator (5.0.0 => dev-main baac3b3)
  - Upgrading sebastian/object-reflector (3.0.0 => dev-main e95c312)
  - Upgrading sebastian/recursion-context (5.0.0 => dev-main d666303)
  - Upgrading sebastian/type (4.0.0 => dev-main e2d71b2)
  - Upgrading sebastian/version (4.0.1 => dev-main c084354)
  - Upgrading slevomat/coding-standard (8.13.4 => dev-master fc778da)
  - Upgrading squizlabs/php_codesniffer (3.7.2 => dev-master 7566b4d)
  - Upgrading symfony/cache (v6.3.4 => 7.0.x-dev a1f7959)
  - Upgrading symfony/cache-contracts (v3.3.0 => dev-main ad94564)
  - Upgrading symfony/console (v6.3.4 => 6.4.x-dev f542ffc)
  - Upgrading symfony/dependency-injection (v6.3.4 => 7.0.x-dev 764510a)
  - Upgrading symfony/deprecation-contracts (v3.3.0 => dev-main 7c3aff7)
  - Upgrading symfony/event-dispatcher (v6.3.2 => 7.0.x-dev c459b40)
  - Upgrading symfony/event-dispatcher-contracts (v3.3.0 => dev-main a76aed9)
  - Upgrading symfony/expression-language (v6.3.0 => 7.0.x-dev 46520d8)
  - Upgrading symfony/filesystem (v6.3.1 => 6.4.x-dev 952a8cb)
  - Upgrading symfony/finder (v6.3.3 => 6.4.x-dev b947e42)
  - Upgrading symfony/form (v6.3.2 => 7.0.x-dev 82cc4c8)
  - Upgrading symfony/options-resolver (v6.3.0 => 6.4.x-dev 22301f0)
  - Upgrading symfony/polyfill-ctype (v1.28.0 => 1.x-dev ea208ce)
  - Upgrading symfony/polyfill-intl-grapheme (v1.28.0 => 1.x-dev 875e90a)
  - Upgrading symfony/polyfill-intl-icu (v1.28.0 => 1.x-dev e46b4da)
  - Upgrading symfony/polyfill-intl-normalizer (v1.28.0 => 1.x-dev 8c4ad05)
  - Upgrading symfony/polyfill-mbstring (v1.28.0 => 1.x-dev 42292d9)
  - Upgrading symfony/polyfill-php72 (v1.28.0 => 1.x-dev 70f4aeb)
  - Upgrading symfony/polyfill-php80 (v1.28.0 => 1.x-dev 6caa573)
  - Upgrading symfony/polyfill-php83 (v1.28.0 => 1.x-dev b0f46eb)
  - Upgrading symfony/polyfill-uuid (v1.28.0 => 1.x-dev 9c44518)
  - Upgrading symfony/process (v6.3.4 => 6.4.x-dev 83264b6)
  - Upgrading symfony/property-access (v6.3.2 => 7.0.x-dev a991a46)
  - Upgrading symfony/property-info (v6.3.0 => 7.0.x-dev b895921)
  - Upgrading symfony/service-contracts (v3.3.0 => dev-main a4025a1)
  - Upgrading symfony/string (v6.3.2 => 7.0.x-dev 9d433d9)
  - Upgrading symfony/translation (v6.3.3 => 7.0.x-dev 6f87c51)
  - Upgrading symfony/translation-contracts (v3.3.0 => dev-main 9fca658)
  - Upgrading symfony/uid (v6.3.0 => 7.0.x-dev 3949585)
  - Upgrading symfony/validator (v6.3.4 => 7.0.x-dev 7eebfcc)
  - Upgrading symfony/var-exporter (v6.3.4 => 7.0.x-dev 7947bc7)
  - Upgrading symfony/yaml (v6.3.3 => 7.0.x-dev dae2dae)
  - Upgrading twig/twig (v3.7.1 => 3.x-dev 3ae6fb8)
  - Upgrading webmozart/glob (4.6.0 => 4.7.x-dev 3c17f7d)
$ vendor/bin/phpunit 
PHPUnit 10.4-dev by Sebastian Bergmann and contributors.

Runtime:       PHP 8.2.7
Configuration: /Volumes/Samsung T7/Sites/serializer/phpunit.xml.dist

.............................................................   61 / 1073 (  5%)
.............................................................  122 / 1073 ( 11%)
.............................................................  183 / 1073 ( 17%)
SS.SS..............................SS.SS.....................  244 / 1073 ( 22%)
.............................................................  305 / 1073 ( 28%)
..SS......................................SS.................  366 / 1073 ( 34%)
.............................................................  427 / 1073 ( 39%)
.............................................................  488 / 1073 ( 45%)
.............................................................  549 / 1073 ( 51%)
.............................................................  610 / 1073 ( 56%)
.............................................................  671 / 1073 ( 62%)
.............................................................  732 / 1073 ( 68%)
.............................................................  793 / 1073 ( 73%)
....................................III......................  854 / 1073 ( 79%)
.............................................................  915 / 1073 ( 85%)
......S...SS....S............................................  976 / 1073 ( 90%)
............................................................. 1037 / 1073 ( 96%)
..S...............S.................                          1073 / 1073 (100%)

Time: 00:01.086, Memory: 76.00 MB

There was 1 PHPUnit test runner deprecation:

1) Your XML configuration validates against a deprecated schema. Migrate your XML configuration using "--migrate-configuration"!

OK, but there were issues!
Tests: 1073, Assertions: 2428, Deprecations: 1, Skipped: 18, Incomplete: 3.

@scyzoryck
Copy link
Collaborator

Thanks for contribution! :)

@scyzoryck scyzoryck merged commit da7d46f into schmittjoh:master Sep 18, 2023
20 of 21 checks passed
@mbabker mbabker deleted the symfony-7 branch September 18, 2023 14:33
@goetas
Copy link
Collaborator

goetas commented Sep 24, 2023

shouldn't this be running on CI as well?

@mbabker
Copy link
Contributor Author

mbabker commented Sep 27, 2023

shouldn't this be running on CI as well?

Eventually, yes. But the CI matrix right now only runs against stable dependency trees, there would need to be at least one build added to run on latest PHP + unstable dependencies to get a build covering Symfony 7 before its stable release (and I don't use ramsey/composer-install so I don't know if I'd be able to easily add it myself).

@scyzoryck scyzoryck mentioned this pull request Sep 28, 2023
Merged
@scyzoryck
Copy link
Collaborator

Here we go :)
https://github.com/schmittjoh/serializer/actions/runs/6344363507/job/17234288415?pr=1515
I would say it will be also useful for the updates like we had before with doctrine packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mbabker @scyzoryck @goetas