Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject an attribute metadata driver into the DoctrineDriver when testing #1520

Conversation

mbabker
Copy link
Contributor

@mbabker mbabker commented Oct 17, 2023

Q A
Bug fix? no
New feature? no
Doc updated no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets Partially #1516
License MIT

Another small test change that will help with the ORM 3.0 compat. Without its classes having the @Annotation annotation anymore in 3.0, there are a lot of Doctrine\Common\Annotations\AnnotationException: [Semantical Error] The class "Doctrine\ORM\Mapping\Entity" is not annotated with @Annotation. style exceptions being thrown. Changing the DoctrineDriverTest to have version conditional behavior and use an annotation or attribute driver as appropriate clears out some of those.

Merging #1471 will help address this in other places in the tests at a later point, but with the hard dependency still in place, those other test classes are not yet updated.

Copy link
Collaborator

@scyzoryck scyzoryck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me! I will merge it on the beginning of the next week with other related PRs. :)

@scyzoryck scyzoryck merged commit dc484a3 into schmittjoh:master Oct 23, 2023
21 of 23 checks passed
@mbabker mbabker deleted the test-doctrine-driver-with-attribute-driver branch October 23, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants