Allow PHPStan PHPDoc parser 2.0 #1572
Conversation
ruudk
commented
Nov 21, 2024
•
ruudk
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| Doc updated | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes] |
| Fixed tickets | |
| License | MIT |
| @@ -37,17 +37,18 @@ | |||
| "require-dev": { | |||
| "ext-pdo_sqlite": "*", | |||
| "doctrine/annotations": "^1.14 || ^2.0", | |||
| "slevomat/coding-standard": "dev-master#f2cc4c553eae68772624ffd7dd99022343b69c31 as 8.11.9999", | |||
There was a problem hiding this comment.
Waiting for slevomat/coding-standard#1713
composer.json
Outdated
| "phpunit/phpunit": "^9.0 || ^10.0 || ^11.0", | ||
| "psr/container": "^1.0 || ^2.0", | ||
| "rector/rector": "^1.0.0", | ||
| "rector/rector": "dev-main#d593c5af24b9ca2da9b7595125dca713f6032bac as 2.0", |
There was a problem hiding this comment.
Waiting for a tagged release: rectorphp/rector#8815
|
It seems I have opened Pandora's box 🤯 @goetas Could you help out? 🙏 |
|
@ruudk could you clarify which help do you need? |
ruudk
force-pushed
the
phpstan-phpdoc-parser
branch
3 times, most recently
from
cee194e to
c49ce1a
Compare
|
@goetas I guess, I don't need help after all. It wasn't so bad. |
|
Since these 2 are dev dependencies, would it be possible to pin them like I did now? Rector will be released on December 12. I have no idea about slevomat/coding-standard Then at least we could remove this blocker for others that want to upgrade to PHPStan 2. /cc @goetas |
|
I have no issue with the changes in the dev dependencies but I ask you kindly to create a new PR with those packages are released. @scyzoryck art you ok with it? |
| @@ -26,7 +26,7 @@ | |||
| "doctrine/instantiator": "^1.3.1 || ^2.0", | |||
| "doctrine/lexer": "^2.0 || ^3.0", | |||
| "jms/metadata": "^2.6", | |||
| "phpstan/phpdoc-parser": "^1.20" | |||
There was a problem hiding this comment.
I do wonder if we can support both - 1.X & 2.x. Without it people that are using slevomat/coding-standard or rector will be not able to use new version of serializer.
At the moment it is a blocker for me as we need to release some bug for the Union types - but I'm fine with releasing it with only 2.x support after releasing bug fix release - soo we would need to wait ~1 week to merge this one.
There was a problem hiding this comment.
that's not possible, as bc break signature, see change https://github.com/schmittjoh/serializer/pull/1572/files#diff-8daba71112686a0487131b9b0f2347a47887f14a6199c712eee72e587e2eba6e
There was a problem hiding this comment.
In theory we can have a hacky if(class_exist(ParserConfig::class)). It will look terrible but most probably it will do the job :)
There was a problem hiding this comment.
We can do that indeed :)
ruudk
force-pushed
the
phpstan-phpdoc-parser
branch
from
c49ce1a to
8545895
Compare
ruudk
changed the title
ruudk
force-pushed
the
phpstan-phpdoc-parser
branch
from
8545895 to
4de1d3c
Compare
ruudk
force-pushed
the
phpstan-phpdoc-parser
branch
from
4de1d3c to
2380860
Compare
|
Anybody an idea about these new PHPStan errors? |
|
I think you can exclude parameters:
# other parameters
excludePaths:
- */Fixtures/* |
ruudk
force-pushed
the
phpstan-phpdoc-parser
branch
from
03cbe7e to
4b85147
Compare
|
You can enable parameters:
# other parameters
reportUnmatchedIgnoredErrors: false |
|
Looks good for me :) I will merge it before the next release. |
