Fix invalid serialization of array with empty object #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
custom stub. Skipped whitelist test for php version which changed behavior. Remove support for php 5.3
…x/fix-invalid-serialization-of-array-with-empty-object-issue-227
empty object. Fixed issue schmittjoh#277 Rely on schmittjoh#292
| @@ -14,7 +13,7 @@ before_script: | |||
| - composer self-update | |||
| - composer install --dev | |||
|
|
|||
| script: phpunit --coverage-clover clover | |||
| script: vendor/bin/phpunit --coverage-clover clover | |||
There was a problem hiding this comment.
these changes are not related to this PR IMO, so they should not be included in it
|
Sorry for the terribly long feedback loop Closing the PR, since too many things changed on master in the last years. If you are still interested in working on this feel free to re-open a new PR based on the current master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to fixed issue with json serialization of array with empty object.
It was serialized like
{'0': {}}and it should be serialized as[{}]this PR should fix it without break all other behavior.Fix issue #277 related with #104
Rely on changes done in #292