Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making test running against phpunit 4.* #369

Merged
merged 1 commit into from
Dec 3, 2014

Conversation

joelwurtz
Copy link

This PR purpose is to allow PHPUnit running all tests, despite the fact that some tests are failing.

Author of original proposed fix in #292 has been kept

The whole PHPUnit configuration changed is only due to switch between windows and unix new line pattern (CRLF -> LF) and add of color=true in PHPUnit configuration.

@joelwurtz joelwurtz force-pushed the fix/travis-unittest branch from f9c8f93 to d89a708 Compare December 2, 2014 21:40
@joelwurtz
Copy link
Author

Test have also been fixed for php5.3

Do you want the fix for failing tests in php 5.4 / 5.5 also in this PR, or should we do that in another PR ?

@joelwurtz
Copy link
Author

See https://travis-ci.org/joelwurtz/serializer/jobs/42792662 for current status of tests

@schmittjoh
Copy link
Owner

Looks good. Could you make one more change, and add phpunit as a dev
dependency, and switch the travis file to use the bundled phpunit version?

I'm aware that this might make things a bit slower on Travis, but I'm happy
to trade a bit of time for more stability.

On Tue, Dec 2, 2014 at 10:50 PM, Joel Wurtz notifications@github.com
wrote:

See https://travis-ci.org/joelwurtz/serializer/jobs/42792662 for current
status of tests


Reply to this email directly or view it on GitHub
#369 (comment).

@joelwurtz joelwurtz force-pushed the fix/travis-unittest branch from d89a708 to aa02788 Compare December 2, 2014 22:06
@joelwurtz
Copy link
Author

should be good

@ternel
Copy link

ternel commented Dec 3, 2014

Yeah, 👍

schmittjoh added a commit that referenced this pull request Dec 3, 2014
Making test running against phpunit 4.*
@schmittjoh schmittjoh merged commit 47cb819 into schmittjoh:master Dec 3, 2014
@schmittjoh
Copy link
Owner

Thanks!

@urakozz urakozz mentioned this pull request Dec 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants