Switch the Twig integration to use non-deprecated APIs #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. 👍 @schmittjoh can you merge it please? |
|
@stof I think A |
|
@soullivaneuh updated |
schmittjoh
added a commit
that referenced
this pull request
Aug 25, 2015
Switch the Twig integration to use non-deprecated APIs
|
When can we expect this change will get tagged? |
|
@stof @schmittjoh This change causes error b/c the string is not callable. The changes in #484 work for me. Can we merge that one instead? |
|
Guys, is this already published? which version has this fix? |
|
@INSEAD-asim only the dev version has it. It is not yet released |
|
@stof , Thanks for update. Any roadmap when it will release? |
|
no idea. I'm not the maintainer of this project. I've been asking for a release since 3 weeks |
|
OK. no issues. I hope somebody else will reply. |
|
@schmittjoh can you tag it please ? |
|
I agree for a tag please :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the library compatible with Twig 2.0, and avoids deprecation warnings in 1.21+
Note that I changed the way the
serialization_contextfunction is compiled. there is no way to wrap this static function into a method of the extension. This will save a method call each time this function is used.