Nullable array inconsistency #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goetas
force-pushed
the
nullable-array
branch
from
1f418c6 to
be10dc6
Compare
|
Similar to #626 |
…"__toString" method)
goetas
force-pushed
the
nullable-array
branch
from
be10dc6 to
62109f5
Compare
|
Hell yeah this one got fixed! Awaiting for the release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #593
Closes #626
Closes #36
Closes #642
Introduced with 8cb1e3c containing a non exact test case
The problem looks to be that the previous test case, having
setSerializeNull(true), expects that:is serialized into
// {"foo":"bar","baz":null}instead of
// {"foo":"bar","baz":null,"0":null}@hashnz do you remember the reason behind this test case?