Document the implied 'Default' property group when no group is specified #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pay attention to https://github.com/schmittjoh/serializer/blob/master/src/JMS/Serializer/Exclusion/GroupsExclusionStrategy.php#L34 The documentation says that there is a |
|
@goetas Ah ha! Thanks for pointing that out. It wasn't apparent that the |
|
i guess the document you tried to change, had the intent do document it :) but an explicit section does not exists probably... interested in adding it? |
|
Yup. I'll back out the last commit and add an explicit statement about it. |
akoebbe
changed the title
|
@goetas let me know if that is clear enough. |
goetas
reviewed
Oct 25, 2016
| You can achieve that by using the ``@Groups`` annotation on your properties. | ||
| You can achieve that by using the ``@Groups`` annotation on your properties. Any | ||
| property without an explicit ``@Groups`` annotation will be included in a | ||
| ``Default`` group, which can be used when specifying groups in the serializer. |
There was a problem hiding this comment.
"...groups in the serialization context." ?
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty sure the example code should be referencing
detailsand notDefault.