Added clearing previous libxml errors #688
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the empty document string
libxml_*
error functions return the previous error, not the error caused by last xml operation.The simple reproduction script:
https://3v4l.org/RKEb0
What it means is that if there is any "previous error" it would mask the problem with
libxml_get_last_error
returning not what the JMSSerializer expects.In this PR I'm sending the test (so the travis run here fails deliberately) that should have passed and that demonstrates initial problem (masked with the lack of
libxml_clear_errors()
call).I additionally sent a php bug report https://bugs.php.net/bug.php?id=73670, to either fix the php documentation or
libxml
-related implementation.In either case, JMSSerializer should handle it properly.