Added translation domain to FormErrorHandler #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why not add an optional parameter to the constructor? without tests, this can't be merged |
Injected translation domain to the constructor, added tests Fixed test issue Fixed FormError issue
|
Injected translation domain param into the constructor and added tests. Please take a look. |
|
looks good to me! thanks @prosalov! |
|
can you update schmittjoh/JMSSerializerBundle#580 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an ability to inject a translation domain parameter (validator.translation_domain) to FormErrorHndler. This is a solution suggestion for the following issue: schmittjoh/JMSSerializerBundle#501