Output class does work now (Sourcery refactored)

[sourcery-ai]

Pull Request #10 refactored by Sourcery.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it.

To incorporate these changes, you can either:

1. Merge this Pull Request instead of the original, or

2. Ask your contributor to locally incorporate these commits and push them to
   the original Pull Request

   Incorporate changes via command line

   git fetch https://github.com/schnipdip/Dump pull/10/head
   git merge --ff-only FETCH_HEAD
   git push

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

• VS Code
• PyCharm

[sourcery-ai]

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.55%.

Quality metrics	Before	After	Change
Complexity	2.85 ⭐	3.38 ⭐	0.53 👎
Method Length	70.65 🙂	71.19 🙂	0.54 👎
Working memory	8.50 🙂	8.67 🙂	0.17 👎
Quality	74.93% 🙂	74.38% 🙂	-0.55% 👎

Other metrics	Before	After	Change
Lines	460	477	17

Changed files	Quality Before	Quality After	Quality Change
linux/dumper/dumper_lcd.py	73.84% 🙂	73.49% 🙂	-0.35% 👎
linux/dumper/dumper_no_lcd.py	76.25% ⭐	75.37% ⭐	-0.88% 👎

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
linux/dumper/dumper_lcd.py	mount_usb	4 ⭐	141 😞	14 😞	53.30% 🙂	Try splitting into smaller methods. Extract out complex expressions
linux/dumper/dumper_no_lcd.py	mount_usb	4 ⭐	111 🙂	12 😞	59.92% 🙂	Extract out complex expressions
linux/dumper/dumper_no_lcd.py	make_udev_rules	0	108 🙂	13 😞	62.72% 🙂	Extract out complex expressions
linux/dumper/dumper_no_lcd.py	verify_usb	5 ⭐	105 🙂	10 😞	63.36% 🙂	Extract out complex expressions
linux/dumper/dumper_no_lcd.py	handle_input_args	3 ⭐	58 ⭐	11 😞	70.33% 🙂	Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

[schnipdip]

We are going to remove this functionality. We don't have to make any changes, in fact we should probably just remove these no_lcd. files.

[schnipdip]

Take a look at the comments, don't forget his has to be under the development branch.

[schnipdip]

This actually has to return lcd because it's what allows you to generate messages. Unless since we are decoupling that from main, we can instantiate the LCD in another file.