Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node 12 support? #23

Closed
achingbrain opened this issue Sep 4, 2020 · 2 comments
Closed

node 12 support? #23

achingbrain opened this issue Sep 4, 2020 · 2 comments

Comments

@achingbrain
Copy link
Contributor

v3 of this module refactored to use esm modules and set the engines field to require node >= 14, yet this module is published transpiled to common js so does run on node 12 at least.

If a user has engine-strict = true or is running yarn, it'll fail to install on node 12 even though it will run.

Can the engines field be relaxed? Node 12 is active LTS for another few months and maintenance LTS until spring 2022 so dropping support seems premature.

Refs: ipfs/js-ipfs#3270

achingbrain added a commit to ipfs/js-ipfs-unixfs that referenced this issue Sep 4, 2020
Downgrades merge-options because v3 removed node 12 support.

Refs: ipfs/js-ipfs#3270
Refs: schnittstabil/merge-options#23
achingbrain added a commit to ipfs/js-ipfs-unixfs that referenced this issue Sep 4, 2020
Downgrades merge-options because v3 removed node 12 support.

Refs: ipfs/js-ipfs#3270
Refs: schnittstabil/merge-options#23
achingbrain added a commit to ipfs/js-ipfs that referenced this issue Sep 4, 2020
Downgrades merge-options because v3 removed node 12 support.

Fixes: #3270
Refs: schnittstabil/merge-options#23
achingbrain added a commit to ipfs/js-ipfs that referenced this issue Sep 4, 2020
Downgrades merge-options because v3 removed node 12 support.

Fixes: #3270
Refs: schnittstabil/merge-options#23
@schnittstabil
Copy link
Owner

@achingbrain thanks contributing, fixed at 3.0.2

@schnittstabil
Copy link
Owner

schnittstabil commented Sep 11, 2020

BTW, this module is not transpiled, but uses an an ESM-Wrapper:

"main": "./index.js",
"exports": {
"require": "./index.js",
"import": "./index.mjs"
},

SgtPooki pushed a commit to ipfs/js-kubo-rpc-client that referenced this issue Aug 18, 2022
Downgrades merge-options because v3 removed node 12 support.

Fixes: ipfs/js-ipfs#3270
Refs: schnittstabil/merge-options#23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants