Skip to content

Commit

Permalink
media: omap3isp: Don't set streaming state on random subdevs
Browse files Browse the repository at this point in the history
The streaming state should be set to the first upstream sub-device only,
not everywhere, for a sub-device driver itself knows how to best control
the streaming state of its own upstream sub-devices.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
  • Loading branch information
Sakari Ailus authored and mchehab committed Aug 15, 2019
1 parent e9eb103 commit 7ef57be
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions drivers/media/platform/omap3isp/isp.c
Original file line number Diff line number Diff line change
Expand Up @@ -719,6 +719,10 @@ static int isp_pipeline_enable(struct isp_pipeline *pipe,
s_stream, mode);
pipe->do_propagation = true;
}

/* Stop at the first external sub-device. */
if (subdev->dev != isp->dev)
break;
}

return 0;
Expand Down Expand Up @@ -833,6 +837,10 @@ static int isp_pipeline_disable(struct isp_pipeline *pipe)
&subdev->entity);
failure = -ETIMEDOUT;
}

/* Stop at the first external sub-device. */
if (subdev->dev != isp->dev)
break;
}

return failure;
Expand Down

0 comments on commit 7ef57be

Please sign in to comment.