Option to leave progress bar visible after finished

[vsekhar]

Option to leave progress bar onscreen when finished. Useful for seeing counts and rates after completing a run.

[schollz]

Great! Would happily accept PR with this

[ibraimgm]

Can I try this one for hacktoberfest?

[schollz]

@ibraimgm of course!

[ibraimgm]

@vsekhar can you giv me more details or a demo where I can better understand your problem? On all the demos, the progress bar remain visible after the run.

[shadowspore]

Wait, but...

progressbar/progressbar.go

Line 210 in 2ec720b

func OptionClearOnFinish() Option {

[michaeltintiuc]

Confirming that progressbar.Default(100) keeps the progress bar visible on completion and the below hides it.

	bar := progressbar.NewOptions(100,
		progressbar.OptionClearOnFinish(),
	)

[ibraimgm]

@vsekhar Does this solve your issue?

[vsekhar]

If my program logs after the bar finishes, then depending on the cursor and output stream (I use go-ansi), the bar either disappears or gets merged/garbled with the next log message.

I think the issue is a lack of newline once the bar finishes. I think you need something like

if !p.config.clearOnFinish {
  if _, err := io.WriteString(c.writer, "\n"); err != nil {
    return err
  }
}

inserted here.

[vidu171]

Is this issue still open?. If it is can I pick it up?

[schollz]

@vidu171 Its open, go ahead!

[vidu171]

Hi, I am not able to recreate this issue my bar is still visible after and it doesn't get merged/garbled with the next log message.
Can you please tell me the steps or sample code to recreate this issue?

[janpfeifer]

I was also having this issue, it seems the problem happens with p.config.userANSICodes is set to true only, since it clears the line after it was re-rendered for finish.

I think simple removing lines 628-633 should solve the issue:

https://github.com/schollz/progressbar/blob/master/progressbar.go#L628

Notice that when not using ANSI Codes, the clearing happen before teh re-rendering, here:

https://github.com/schollz/progressbar/blob/master/progressbar.go#L609

[janpfeifer]

Simple 0.5 line fix, at least for the case with config.useANSICodes: #140