-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EditorConfig] Disable properties that use "unset" or invalid values. #47
Comments
Hi @EricDunsworth, |
Any news on this ? |
I've opened a PR #295 to handle this issue. I would by happy to see your feedback on this. |
Co-authored-by: Barthélemy Laurans <barthelemy.laurans.external@salomon.com>
Co-authored-by: Barthélemy Laurans <bartheleway@gmail.com>
Co-authored-by: Barthélemy Laurans <bartheleway@gmail.com>
This is merged to |
This is now available in version 0.12.0. 🥳 |
Lintspaces' editorconfig option currently has inconsistent support for properties that have been set to be disabled. A few seem to work, but most don't. Not sure if the ones that already work are by design.
EditorConfig's documentation claims that the
unset
value can be used to disable any property (including ones that were set earlier). Beforeunset
was officially decided upon in editorconfig/editorconfig#287, editorconfig/editorconfig#262 (comment) had recommended using any invalid value to achieve the same effect.Would it be possible to fully support disabling properties?
Code/Output samples...
The samples below demonstrate how lintspaces currently reacts to disabled properties.
.editorconfig
test.txt
check.js
Output when running
node check.js
in Windows:Expected output of
node check.js
:The text was updated successfully, but these errors were encountered: