React v15.5 prop types fix #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k.github.io/react/docs/typechecking-with-proptypes.html) Changed prop_types.js to use the npm library ‘prop-types’ instead of react’s PropTypes
|
@toriaezunama I guess this is breaking change and should be published with new major version. Like when using React older than 15.5 use 1.x otherwise 2.x ? |
|
Yes, I agree. Bumping the major version indicates breaking changes and this would break for everyone who isn't on the latest version of React. |
D-TUCKER
approved these changes
May 30, 2017
|
Hi everyone, |
|
@oallouch: I am on it! |
schovi
approved these changes
Jun 5, 2017
|
It is up as 2.0.0 |
|
All good for me. |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React.PropTypes is deprecate in V15.5 so updated to use prop-types library. Also, updated react related libraries to use the latest