Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea for additional feature (File Transfer) #8

Closed
frct1 opened this issue Mar 3, 2018 · 6 comments
Closed

Idea for additional feature (File Transfer) #8

frct1 opened this issue Mar 3, 2018 · 6 comments

Comments

@frct1
Copy link

frct1 commented Mar 3, 2018

Hi, how do you like the idea to add the ability to download files from the server (filetransfer) and download files to it. With this ability user will can create even more interesting features with the library

@schroffl
Copy link
Owner

schroffl commented Mar 3, 2018

I already created a package for that: teamspeak-filesystem ;)

@schroffl
Copy link
Owner

schroffl commented Mar 5, 2018

I noticed that teamspeak-filesystem might not work right now, because Line 75 relies on the host property of the teamspeak-query instance, which I removed in 8cea6c6.
The easiest fix would be to revert the aforementioned commit (which is a good thing anyways, regarding backwards compatibility) or to update teamspeak-filesystem to use net.Socket.remoteAddress and net.Socket.remotePort.

schroffl added a commit that referenced this issue Mar 5, 2018
This reintroduces the 'sock' and 'host' properties for backwards-
compatibility. See #8 for more information.
@schroffl
Copy link
Owner

schroffl commented Mar 6, 2018

The easy fix I was talking about is published in v2.0.1.

@frct1
Copy link
Author

frct1 commented Mar 8, 2018

Hi, sorry for missing. Was out of town.
Today will test teamspeak-filesystem, by code review it's looking pretty good.
I`m now started learning meteor, how you think, do it possible connect this framework with your library ?

@schroffl
Copy link
Owner

schroffl commented Mar 8, 2018

This library cannot be used in the browser, but as long as you use it on the backend and somehow exchange the information with the client it should be fine.

I don't know anything about meteor, so I can't help you with that, sorry.

@schroffl
Copy link
Owner

schroffl commented Mar 15, 2018

I'm closing this issue due to inactivity.

@schroffl schroffl changed the title Idea for additional feature Idea for additional feature (File Transfer) Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants