[dotnet] use correct devtools session id after reinitialization

Fix regression issue, appeared in v4.17. Closing a tab breaks the devtools session Fixes SeleniumHQ#13755
schrufygroovy · Apr 3, 2024 · bacefcc · bacefcc
1 parent 911b312
commit bacefcc
Show file tree

Hide file tree

Showing 2 changed files with 40 additions and 8 deletions.
diff --git a/dotnet/src/webdriver/DevTools/DevToolsSession.cs b/dotnet/src/webdriver/DevTools/DevToolsSession.cs
@@ -239,9 +239,15 @@ public T GetVersionSpecificDomains<T>() where T : DevToolsSessionDomains
         /// <param name="throwExceptionIfResponseNotReceived"><see langword="true"/> to throw an exception if a response is not received; otherwise, <see langword="false"/>.</param>
         /// <returns>The command response object implementing the <see cref="ICommandResponse{T}"/> interface.</returns>
         //[DebuggerStepThrough]
-        public Task<JToken> SendCommand(string commandName, JToken commandParameters, CancellationToken cancellationToken = default(CancellationToken), int? millisecondsTimeout = null, bool throwExceptionIfResponseNotReceived = true)
+        public async Task<JToken> SendCommand(string commandName, JToken commandParameters, CancellationToken cancellationToken = default(CancellationToken), int? millisecondsTimeout = null, bool throwExceptionIfResponseNotReceived = true)
         {
-            return SendCommand(commandName, ActiveSessionId, commandParameters, cancellationToken, millisecondsTimeout, throwExceptionIfResponseNotReceived);
+            if (this.attachedTargetId == null)
+            {
+                LogTrace("Session not currently attached to a target; reattaching");
+                await this.InitializeSession().ConfigureAwait(false);
+            }
+
+            return await SendCommand(commandName, this.ActiveSessionId, commandParameters, cancellationToken, millisecondsTimeout, throwExceptionIfResponseNotReceived);
         }
 
         /// <summary>
@@ -262,12 +268,6 @@ public T GetVersionSpecificDomains<T>() where T : DevToolsSessionDomains
                 millisecondsTimeout = Convert.ToInt32(CommandTimeout.TotalMilliseconds);
             }
 
-            if (this.attachedTargetId == null)
-            {
-                LogTrace("Session not currently attached to a target; reattaching");
-                await this.InitializeSession().ConfigureAwait(false);
-            }
-
             var message = new DevToolsCommandData(Interlocked.Increment(ref this.currentCommandId), sessionId, commandName, commandParameters);
 
             if (this.connection != null && this.connection.IsActive)

diff --git a/dotnet/test/common/DevTools/DevToolsTabsTest.cs b/dotnet/test/common/DevTools/DevToolsTabsTest.cs
@@ -0,0 +1,32 @@
+using NUnit.Framework;
+using System.Threading.Tasks;
+
+namespace OpenQA.Selenium.DevTools
+{
+    using CurrentCdpVersion = V123;
+
+    [TestFixture]
+    public class DevToolsTabsTest : DevToolsTestFixture
+    {
+
+        [Test]
+        [IgnoreBrowser(Selenium.Browser.IE, "IE does not support Chrome DevTools Protocol")]
+        [IgnoreBrowser(Selenium.Browser.Firefox, "Firefox does not support Chrome DevTools Protocol")]
+        [IgnoreBrowser(Selenium.Browser.Safari, "Safari does not support Chrome DevTools Protocol")]
+        public async Task ClosingTabDoesNotBreakDevToolsSession()
+        {
+            var domains = session.GetVersionSpecificDomains<CurrentCdpVersion.DevToolsSessionDomains>();
+            await domains.Console.Enable();
+            var oldWindowHandle = driver.CurrentWindowHandle;
+            driver.SwitchTo().NewWindow(WindowType.Tab);
+            driver.SwitchTo().Window(oldWindowHandle);
+            driver.Close();
+            Assert.That(
+                async () => {
+                    await domains.Console.Enable();
+                },
+                Throws.Nothing
+            );
+        }
+    }
+}