Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global Statistics #9

Open
wichtounet opened this issue Jan 25, 2016 · 4 comments
Open

Global Statistics #9

wichtounet opened this issue Jan 25, 2016 · 4 comments

Comments

@wichtounet
Copy link

Hi,

As discussed in issue #6, I think it would be great to get some total statistics.

For starter, simply the total number of instantiations. Ideally, this number would be updated by the filters. This could also probably be done for each node type (template instantiation, memoization, deduced...).

The total duration could also be interesting. This would be the sum of the durations of all templates of first level in the graph.

Another thing that would be great but maybe harder to get is the number of instantiations of each template. For instance, the number of times std::forward has been instantiated.

What do you think ?

@schulmar
Copy link
Owner

All of these are reasonable. I cannot say how long it will take to implement each of them.

  • total number of instantiations
  • -"- updated by filters
  • -"- per node type (template instantiation, memoization, deduced...)
  • total duration

@schulmar
Copy link
Owner

schulmar commented Feb 1, 2016

I added some of the statistics in the status bar, the tooltip gives more information.

Please comment on their usability.

@wichtounet
Copy link
Author

Hi,

I just tested the new branch. I really like it :) I think that these are very good metrics for comparison between different builds/versions.

Maybe the tooltip on duration is a bit too detailed or should be wrapped. Aside from this point, I think it is pretty good.

Using the status is imho the best way to achieve this. It is very visible and accessible.

Thanks a lot

@schulmar
Copy link
Owner

@wichtounet I removed the request for the number of instantiations per template. This is a larger point and should be in its own issue. Maybe this should even be in its own tool but I am not sure about that.

If you think that this functionality should be part of Templar, you can open a separate issue for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants