Use X-OAuth-Scopes response header to determine missing scopes #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than blindly suggesting the user refresh their token, we can use the X-OAuth-Scopes header on the API response to determine if the user is lacking them in the first place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6
A GitHub API response includes an
X-OAuth-Scopesheader that we can use to determine if a user is getting an error due to the lack of required scopes.This change improves on the approach in #4 by checking that header in the event of a parse failure. This allows us to give more certain troubleshooting advice in that case (and makes it less likely that we'll give advice that won't fix the problem).