Do not count packets that are still within their timeout window in packet loss calculation. #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 21, 2019 11:42
…ppy ascii art Todo, put sent times in window instead?
and timeout. Window size is no longer critical, and results are correct when timeout is not a multiple of period.
|
Thanks for the patch! I don't have much time to look at this right now, but I certainly will. I worry a bit about performance aspects, so I will need to verify the cost of this. |
|
This is now fixed with a different implementation in #193 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #156 .
Adds a circular buffer of ping sent times
int *windowof length at least ceil(timeout/period). Entries are set to the send time when the ping is sent, and cleared (set to int_min) when a response is received.During the per-receive stats print out
www.csh.rit.edu : [3], 228 bytes, 77.4 ms (77.5 avg, 42% loss)these sent times are compared to the current time + the timeout. Any requests that are still unanswered, but within their timeout window, are excluded from the packet loss calculation.Please excuse all the extra
fprintfs, I will clean out my debugging output as I finalize this PR, if you indicate that it might be accepted.Thank you!