Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix xmt stats in Netdata output #172

Merged
merged 1 commit into from
Mar 1, 2020
Merged

Fix xmt stats in Netdata output #172

merged 1 commit into from
Mar 1, 2020

Conversation

vlvkobal
Copy link
Contributor

There was a difference in stats for received/transmitted packets when the Netdata protocol was used.

BEGIN fping.google_com_packets
SET xmt = 5
SET rcv = 5
END
BEGIN fping.google_com_quality
SET returned = 100
END
BEGIN fping.google_com_latency
SET min = 2793
SET avg = 2798
SET max = 2801
END
BEGIN fping.google_com_packets
SET xmt = 5
SET rcv = 4
END
BEGIN fping.google_com_quality
SET returned = 100
END
BEGIN fping.google_com_latency
SET min = 2781
SET avg = 2787
SET max = 2794
END
...
BEGIN fping.google_com_packets
SET xmt = 5
SET rcv = 4
END
BEGIN fping.google_com_quality
SET returned = 100
END
BEGIN fping.google_com_latency
SET min = 2789
SET avg = 2794
SET max = 2800
END
BEGIN fping.google_com_packets
SET xmt = 4
SET rcv = 4
END
BEGIN fping.google_com_quality
SET returned = 100
END
BEGIN fping.google_com_latency
SET min = 2790
SET avg = 2794
SET max = 2804
END
BEGIN fping.google_com_packets
SET xmt = 5
SET rcv = 5
END
BEGIN fping.google_com_quality
SET returned = 100
END
BEGIN fping.google_com_latency
SET min = 2786
SET avg = 2795
SET max = 2803
END

The correction for num_sent_i was moved to the appropriate place. The output for Netdata is sane now.

BEGIN fping.google_com_packets
SET xmt = 4
SET rcv = 4
END

@coveralls
Copy link

Coverage Status

Coverage remained the same at 79.401% when pulling edf8475 on vlvkobal:develop into bc5017b on schweikert:develop.

h->discard_next_recv_i = 1;
}
}

if (!sent_charts) {
printf("CHART fping.%s_packets '' 'FPing Packets for host %s' packets '%s' fping.packets line 110020 %d\n", h->name, h->host, h->name, report_interval / 100000);
printf("DIMENSION xmt sent absolute 1 1\n");
Copy link
Contributor

@ilyam8 ilyam8 Feb 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice you swap received and sent. It is common pattern in netdata - received goes first and has green color.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad currently: when green > red

after swap: when red > green

@schweikert
Copy link
Owner

Thanks!

@schweikert schweikert merged commit 25e30da into schweikert:develop Mar 1, 2020
laddp pushed a commit to laddp/fping that referenced this pull request Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants