Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macos: use AI_UNUSABLE hint for getaddrinfo() #174

Merged
merged 1 commit into from
Feb 29, 2020

Conversation

tycho
Copy link
Contributor

@tycho tycho commented Feb 27, 2020

On Mac OS, the getaddrinfo behavior differs from Linux. If you do something silly like request address info for AF_INET6 with an IPv4 address, it succeeds. Because of this, something like fping -6 127.0.0.1 fails at sendmsg time instead of address resolution time. There's a special hint flag that you can set on Mac OS to make getaddrinfo behave like it would on Linux (and thus, pass the test suite).

Signed-off-by: Steven Noonan <steven@uplinklabs.net>
@coveralls
Copy link

Coverage Status

Coverage remained the same at 79.401% when pulling 5187f5b on tycho:macos-unbreak-getaddrinfo into bc5017b on schweikert:develop.

@schweikert schweikert merged commit 589d326 into schweikert:develop Feb 29, 2020
@tycho tycho deleted the macos-unbreak-getaddrinfo branch June 10, 2020 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants