fping: retain privileges until after privileged setsockopt #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Linux, one needs privileges to setsockopt(SO_BINDTODEVICE), and the current code would drop setuid root privileges too soon. Temporarily drop privileges instead, and raise them back to issue the privileged setsockopt(). Once we know we won't need to do any further privileged setsockopt(), permanently drop privileges. For now, assume SO_BINDTODEVICE is the only setsockopt that needs this.
|
Related to issue #199 |
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Linux, one needs privileges to setsockopt(SO_BINDTODEVICE), and the
current code would drop setuid root privileges too soon.
Temporarily drop privileges instead, and raise them back to issue the
privileged setsockopt(). Once we know we won't need to do any further
privileged setsockopt(), permanently drop privileges.
For now, assume SO_BINDTODEVICE is the only setsockopt that needs this.