-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --fwmark option for Linux #289
Conversation
16f9fd4
to
357f2e7
Compare
Thanks for your contribution! Could you add a simple test to check at least that the program doesn't crash when --fwmark is passed? Pinging 12.0.0.7 is fine, and you don't need to check that the fwmark was actually set (that would be hard to do). Also, please update doc/fping.pod (the man-page). |
Thanks for the review! Done. |
5588d31
to
5ad290a
Compare
Apologies, it looks like setcap doesn't work in GitHub CI, which made the test fail. I've now used sudo instead. I believe it should work now. |
54e5165
to
2d6cf95
Compare
Update: the tests finally pass in GitHub CI in my repo after a couple more iterations. Thanks for your patience. |
This is based on tomangert's original outdated pull request.
--fwmark can be used in conjunction with
ip rule
andip route
to route ping packets based on the mark set by the aforementioned flag.This has been supported by Linux since kernel version 2.6.25
Let me know if you'd like any changes.