Add additional tests #292
Merged
Add additional tests #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* wrong number or kind of arguments fails and prints usage; * an empty range silently pings nothing and fping returns 1; * a too large range fails with an error message; * a zero CIDR prefix length fails with an error message.
The statistics printed every SECS seconds show the results since the the last report, not since the beginning. Also, every report starts with a timestamp.
The -o option adds outage duration to the periodic reports. Each report shows the outage since the last report, not since the beginning.
The man page gives two examples combining -C and -q, but these combinations are not yet tested. Add tests to help ensure the documented examples continue to work.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits one through four add tests for existing functionality that I added in my (now closed) pull requests for new functionality. Commit five adds two tests for examples given in the man page.