Print returned TOS value #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsnw
force-pushed
the
issue/68
branch
2 times, most recently
from
093bae5 to
5d55aa8
Compare
auerswal
reviewed
Jul 20, 2024
|
I like the general approach of using an option to enable printing of received TOS values. I also like to approach of starting with the default output ( |
|
I have changed the logic a bit and --print-tos can be used independently of the -O parameter. |
auerswal
approved these changes
Jul 27, 2024
|
Perfect, can you merge that please? I made a few changes to my github account and lost my permissions as a result |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tos to the header again, but only for IPv4.
IPv6 uses ds field here
Currently, TOS is only output in one place as in the ticket example.
Issue #68