Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning unused parameter 'reply_timestamp' under macOS #348

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

gsnw-sebast
Copy link
Collaborator

Under macOS the following build warning is fixed

gcc -DHAVE_CONFIG_H -I. -I..    -Wall -Wextra -Wno-sign-compare -DIPV6 -g -O0 -fprofile-arcs -ftest-coverage -MT fping-fping.o -MD -MP -MF .deps/fping-fping.Tpo -c -o fping-fping.o `test -f 'fping.c' || echo './'`fping.c
fping.c:2027:14: warning: unused parameter 'reply_timestamp' [-Wunused-parameter]
    int64_t *reply_timestamp,
             ^
1 warning generated.

@coveralls
Copy link

Coverage Status

coverage: 87.526% (-0.2%) from 87.746%
when pulling 9cef0be on gsnw:macos-reply_timestamp
into c0eb514 on schweikert:develop.

Copy link
Collaborator

@auerswal auerswal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good. :-)

The changes look plausible. Without these changes, the macOS build on the GitHub CI reports the warning. With them, it does not.

@auerswal auerswal merged commit c8b8141 into schweikert:develop Aug 31, 2024
6 of 9 checks passed
@gsnw-sebast gsnw-sebast deleted the macos-reply_timestamp branch September 1, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants