Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature: support ICMP type 13/14 timestamps #351

Closed
wants to merge 1 commit into from

Conversation

gsnw-sebast
Copy link
Collaborator

@gsnw-sebast gsnw-sebast commented Sep 23, 2024

This is a development branch. (Issues: #265)

The current version has no output yet, but can be tested with GDP. Please note that root rights are required for icmp type 13 queries

Build

./autogen.sh
./configure --enable-debug
make CFLAGS="-g -O0 -fprofile-arcs -ftest-coverage"

GDB Usage

gdb fping
set args --icmp-timestamp 127.0.0.1
break fping.c:2289

print *icp

@coveralls
Copy link

coveralls commented Sep 23, 2024

Coverage Status

coverage: 86.772% (-0.8%) from 87.614%
when pulling b70a947 on gsnw:icmp-13_and_14-dev
into b32852c on schweikert:develop.

@gsnw-sebast
Copy link
Collaborator Author

The current update outputs the output directly with ./fping --icmp-timestamp 127.0.0.1

I'm still thinking about putting the ip header returns from decode_icmp_ipv4 into an extra structure. Because the many returns make it a bit overloaded

@gsnw-sebast gsnw-sebast force-pushed the icmp-13_and_14-dev branch 3 times, most recently from 5c88508 to 833b961 Compare October 8, 2024 17:50
@gsnw-sebast
Copy link
Collaborator Author

Development is finished and therefore the pull-request is closed and a new one is created with the final version

@gsnw-sebast gsnw-sebast closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants