Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Netcdf #53

Merged
merged 22 commits into from
Jan 8, 2020
Merged

Netcdf #53

merged 22 commits into from
Jan 8, 2020

Conversation

rcnijzink
Copy link
Contributor

I moved all the write-subroutines to a separate file, and added here netcdf-functionality.

@rcnijzink
updated makefile for netcdf
1d62770
@rcnijzink
added description on installing netcdf
c55fb6b
@rcnijzink
added file for writing data to netcdf
e6f818f
@rcnijzink
added units and wrote all variables to netcdf
0ee9413
@rcnijzink
corrected start date in netcdf
cf8bfe9
@rcnijzink
moved write_daily to separate f90-file
b230567
@rcnijzink
tried to move write_yearly to separate f90-file
0513179
@rcnijzink
changed travis to install fortran netcdf
725f98f
@rcnijzink
added netcdf and text writing in the same subroutines; added flag to …
be6b1a8 
…write to nc
@rcnijzink
added flag for netcdf to namelist
fec4956
@rcnijzink
added netcdf filenames in modules
19e1e73
@rcnijzink
added netcdf for rsurf
5cc2803
@rcnijzink
added definitions for other netcdf files
f21d0bb
@rcnijzink
added writing to netcdf for yearly values
f0588b8
@rcnijzink
correct some mistakes
79d2a84
@rcnijzink
corrected mistake in nc write-yearly
52b1280
@rcnijzink
correct hourly timestamp
b347c4e
@rcnijzink
added calculation of julian data
a12a302
@rcnijzink
corrected timestamps and set time relative to 1-1-1900; added i_lon t…
de293bd 
…o namelist
@rcnijzink
added i_lon to namelists
6f6480d
@rcnijzink
updated documentation
d79e99e
@rcnijzink
updated documentation
47dced1
schymans
schymans reviewed Jan 7, 2020
View reviewed changes
Copy link
Owner

@schymans schymans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks! However, could you verify if the old output can still be generated and if the model can still be compiled and run without netcdf? The code does not look like it. It would also be good to include the netcdf option in the documentation.

VOM_Fortran/VOM-docu/source/outputfiles.rst Show resolved Hide resolved
VOM_Fortran/VOM-docu/source/quickstart.rst Show resolved Hide resolved
VOM_Fortran/VOM-code/modules.f90 Show resolved Hide resolved
@rcnijzink
Copy link
Contributor Author

So the only issue here is that you have to have netcdf-fortran installed before compiling. Will check if I could add something to look for that in the Makefile, but as you use a library ( you do "use netcdf" before a subroutine runs that uses it) this might be problematic. Installation is however just a simple one liner.

@schymans schymans merged commit 5316ef9 into schymans:master Jan 8, 2020
@rcnijzink rcnijzink mentioned this pull request Jan 9, 2020
Closed
@rcnijzink rcnijzink deleted the netcdf branch January 13, 2020 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schymans schymans schymans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rcnijzink @schymans