FIX: If #32
FIX: If #32
Conversation
|
This seems similar to what I tried at sympy/sympy#23732 and sympy/sympy#23801, but maybe I misunderstood the YAML syntax (I used "Build Docs Preview" instead of "build_docs" because that is what I named the job in my circle CI config). |
|
I would recommend you dump the I don't see why it wouldn't work if you have the variable names correct. for 9eceb30 there is more than just the CircleCI job, but our actions list only shows 3 jobs (circle waiting, then running/pending, then success I think): https://github.com/larsoner/circleci-artifacts-redirector-action/actions This is (I think) because of the line in |
|
Well not 100% success on MNE-Python, but at least now they show as skipped:
|
|
@asmeurer you'll also want to add the conditional about the "check URL" step as it's not valid until the job completes. So if you try to check it while the job is in the "pending" state, it will fail |
| - The action has an outtput ``url`` that you can use in downstream steps, but | ||
| this URL will only point to a valid artifact once the job is complete, i.e., | ||
| `github.event.status` is either `'success'`, `'fail'`, or (maybe) `'error'`, | ||
| not `'pending'`. |
There was a problem hiding this comment.
@asmeurer this bit, implemented this way for this repo
I think things have been green since then...
https://github.com/larsoner/circleci-artifacts-redirector-action/actions
This is a continuation of sympy#23732 and sympy#23801 based on the instructions at scientific-python/circleci-artifacts-redirector-action#32. Assuming it works this time, it will fix sympy#23784 (but there's no way to know if it works until merging it).
|
OK, well if you got it working, that's a little more promising. I'm trying it at SymPy here, but there's no way to know if it will work until that is merged and a few other CI builds on other PRs happen. |
|
It didn't seem to work. |
|
To be clear, this is what I consider "working": https://github.com/mne-tools/mne-python/actions
So some are at least skipped. Do you not get this using a similar output when doing something like: |
|
This is what our actions log looks like https://github.com/sympy/sympy/actions
(the skipped "report CI results to PR" run in that log is a different build). And this is our build file https://github.com/sympy/sympy/blob/master/.github/workflows/docs-preview.yml. The only difference I see is I renamed the build to "Build Docs Preview", so maybe I somehow messed up the reference there? Of course, showing as skipped is better than failed, but the ideal solution would be if it didn't show up at all. I don't know if that's possible. Otherwise, the "actions" tab becomes completely useless, because the "real" builds are buried under hundreds of skipped Circle CI redirector builds. |
I wonder if the spaces are problematic or something 😞
It does not seem possible currently, see #27 (comment) I'll merge this since it seems to work in a few places at least, as the SciPy variant implemented in scipy/scipy#17018 seems to be working as well:
|
@asmeurer can you try this? It might work. The job title is in the context, so if I got the conditional right I think it should only run for the correct status(es).