Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update & split docs page into tutorial and guide #180

Merged
merged 3 commits into from
Jun 29, 2023

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Jun 24, 2023

Updates based on repo-review's docs.

The current "writing-docs" page was mostly moved to a tutorial, and a more complete guide-style page was added. Both are under "docs".

Also added a few repo-review checks for .readthedocs.yaml.

@henryiii henryiii force-pushed the henryiii/feat/docs branch 2 times, most recently from 0d578cd to 722fb9b Compare June 26, 2023 22:27
@henryiii henryiii mentioned this pull request Jun 27, 2023
@henryiii henryiii force-pushed the henryiii/feat/docs branch 3 times, most recently from f6eb03f to 5014eb0 Compare June 27, 2023 21:14
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii changed the title feat: update docs a bit feat: update docs & split into tutorial and guide Jun 27, 2023
@henryiii henryiii changed the title feat: update docs & split into tutorial and guide feat: update & split docs page into tutorial and guide Jun 28, 2023
@henryiii henryiii marked this pull request as ready for review June 28, 2023 17:54
@henryiii
Copy link
Collaborator Author

henryiii commented Jun 29, 2023

Thanks @jarrodmillman! @danielballan, feel free to comment even after it's merged, I can do further fixes in a followup. Will merge soonish since I'm working on adding a check list to the README & this adds new checks.

@henryiii henryiii merged commit fd07d70 into main Jun 29, 2023
@henryiii henryiii deleted the henryiii/feat/docs branch June 29, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants