Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add PEP 621 support (flit and trampolim) #21

Merged
merged 7 commits into from
Jun 12, 2021
Merged

feat: add PEP 621 support (flit and trampolim) #21

merged 7 commits into from
Jun 12, 2021

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Jun 11, 2021 •
edited
Loading

Added PEP 621 support for Flit and added trampolim.

  • Flit SDists have bad dist-info files that produces twine warnings, but that's not new.
  • Trampolim products don't pass twine due to twine not supporting metadata 2.2 - skipping check
    • Needed a duplicate CI file due to upload action checking by default - also added "pre"-check for non-release runs.
  • Trampolim doesn't support /src structure (or editable installs) yet (at least src should come soon, thanks to @FFY00), so that one does not make /src structure for now. Support for src structure FFY00/trampolim#3
  • Trampolin is Python 3.7+, but wheels should support 3.6+, I'd think.

@henryiii henryiii changed the title feat: add PEP 621 support feat: add PEP 621 support (flit and trampolim) Jun 11, 2021
@henryiii henryiii mentioned this pull request Jun 11, 2021
Closed
jugmac00
jugmac00 reviewed Jun 11, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
@henryiii henryiii force-pushed the henryiii/ci/testctx branch 3 times, most recently from 19db604 to 17e3181 Compare June 11, 2021 23:33
@henryiii henryiii mentioned this pull request Jun 12, 2021
Closed
@henryiii
Copy link
Collaborator Author

henryiii commented Jun 12, 2021 •
edited
Loading

Details:

  • Trampolim products don't pass twine due to twine not supporting metadata 2.2 - skipping check
    • Needed a duplicate CI file due to upload action checking by default - also added "pre"-check for non-release runs.
  • Flit SDists have bad dist-info files that produces twine warnings, but that's not new.
  • Trampolim doesn't support /src structure (or editable installs) yet (at least src should come soon, thanks to @FFY00), so that one does not make /src structure for now. Support for src structure FFY00/trampolim#3

@henryiii henryiii enabled auto-merge (rebase) June 12, 2021 04:47
@henryiii henryiii disabled auto-merge June 12, 2021 04:51
@henryiii henryiii force-pushed the henryiii/ci/testctx branch 2 times, most recently from 6861a72 to 322b977 Compare June 12, 2021 05:05
@henryiii henryiii enabled auto-merge (rebase) June 12, 2021 05:13
@henryiii henryiii force-pushed the henryiii/ci/testctx branch 3 times, most recently from dc4958f to 1bbe64c Compare June 12, 2021 05:24
@henryiii henryiii merged commit 48c7b56 into main Jun 12, 2021
@henryiii henryiii deleted the henryiii/ci/testctx branch June 12, 2021 05:35
@henryiii henryiii mentioned this pull request Jun 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FFY00 FFY00 FFY00 left review comments

@jugmac00 jugmac00 jugmac00 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@henryiii @jugmac00 @FFY00