-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: switch pre-commit
action to bot
#114
base: main
Are you sure you want to change the base?
Conversation
ci: | ||
autofix_prs: true | ||
autoupdate_commit_msg: "[pre-commit.ci] pre-commit suggestions" | ||
autoupdate_schedule: quarterly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
autoupdate_schedule: quarterly | |
autoupdate_schedule: monthly |
to be aligned with dependabot - https://github.com/scientific-python/lazy_loader/blob/2031223913c7e592c1c59aec72f296e9d08171fa/.github/dependabot.yml#L12
Thanks!! I will review these next week. I try to keep several different repos linting/ci stuff in sync so I can automate these kinds of linting / CI changes at the same time. So I will update the other repos at the same time. |
@jarrodmillman, did you have a chance to have a look at this PR? 🦩 |
I am busy working on a grant proposal and a progress report for another grant that are due next week. I will take care of your PRs after that. I know they shouldn't take much time, but I am just swamped at the moment. |
@jarrodmillman no worries 🎏 just let me know when you could check it... 🐿️ |
mind have a look, when you have time 🦩 |
hello, any chance you may have some time to check this PR? |
Thanks for the PR, @Borda. I wonder if it's necessary to use the bot? We already get autofixes when we mention the bot by name: |
interesting, did not know it, but does it also work for forked PRs? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
=======================================
Coverage 95.74% 95.74%
=======================================
Files 5 5
Lines 235 235
=======================================
Hits 225 225
Misses 10 10 ☔ View full report in Codecov by Sentry. |
Yes, as long as you don't need tokens, then you can run the action on PRs (take a look, e.g., at the other PRs in this repo). You can't rewrite them, but the bot can be manually invoked in those instances. Anyway, appreciate you investigating CI improvements :) |
@jarrodmillman I wonder if there is a reason why using local GH action for lining and not the free bot - https://github.com/marketplace/pre-commit-ci but with this bot, you can also get automated fixes for lint
But before eventual merging, the bot needs to be installed so there is no degradation of code quality :)
Also, you can add a badge (the link will be available also upon installation)