Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: merge coverage with regular CI tests #116

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Borda
Copy link

@Borda Borda commented Apr 6, 2024

This could simplify maintenance as the testing and reporting coverage workflows are almost the same, so let's add reporting coverage to the main one and drop the additional/duplicate...

@jarrodmillman
Copy link
Member

We have the separate because we run the tests on multiple platforms and multiple python versions, but we only want to run coverage reports on one platform and one python version. This is the standard pattern on most Scientific Python projects.

@jarrodmillman jarrodmillman marked this pull request as draft April 6, 2024 20:06
@Borda
Copy link
Author

Borda commented Apr 6, 2024

We have the separate because we run the tests on multiple platforms and multiple python versions, but we only want to run coverage reports on one platform and one python version. This is the standard pattern on most Scientific Python projects.

I see, but with Codecov, id does a fusion of all received reports for a particular commit, and with the newly added flags/tags, you can validate what lines are visited only for a specific configuration...

Anyway, just a suggestion, and feel free to close it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants