Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid conflicts when function is implemented in same-named submodule #9

Merged
merged 2 commits into from
Jun 3, 2022
Merged

Avoid conflicts when function is implemented in same-named submodule #9

merged 2 commits into from
Jun 3, 2022

Conversation

stefanv
Copy link
Member

@stefanv stefanv commented May 17, 2022 •
edited
Loading

Supersedes #8

@stefanv stefanv mentioned this pull request May 17, 2022
Closed
@jarrodmillman jarrodmillman requested a review from tupui May 17, 2022 20:55
adrinjalali
adrinjalali reviewed May 19, 2022
View reviewed changes
tests/test_lazy_loader.py
Comment on lines +104 to +105
assert isinstance(fake_pkg.some_func, types.FunctionType)
assert isinstance(fake_pkg.some_func, types.FunctionType)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we test that from fake_pkg.some_func import some_func also works?

In codebases where this happens, some people do from fake_pkg import some_func and some do from fake_pkg.some_func import some_func and both work.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I added a test for that.

@adrinjalali adrinjalali mentioned this pull request May 23, 2022
Merged
@TortoiseHam
Copy link

any updates on a timeline for this change?

@stefanv stefanv merged commit 2cf220b into scientific-python:main Jun 3, 2022
@stefanv
Copy link
Member Author

stefanv commented Jun 3, 2022

Merged, let's see how it goes.

@TortoiseHam
Copy link

awesome :) Do you anticipate a new rc release with this in the immediate future?

@jarrodmillman jarrodmillman added this to the 0.1 milestone Aug 25, 2022
@jarrodmillman
Copy link
Member

@TortoiseHam Please open an issue if you run into any issues:
https://pypi.org/project/lazy_loader/0.1rc3/

@jarrodmillman
Copy link
Member

@adrinjalali It would be great if you could test out:
https://pypi.org/project/lazy_loader/0.1rc3/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrinjalali adrinjalali adrinjalali approved these changes

@jarrodmillman jarrodmillman jarrodmillman approved these changes

@tupui tupui Awaiting requested review from tupui

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1
Development

Successfully merging this pull request may close these issues.
4 participants
@stefanv @TortoiseHam @jarrodmillman @adrinjalali