-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip __main__.py #232
Skip __main__.py #232
Conversation
Thanks! Please also add a change log entry to https://github.com/scientific-python/pytest-doctestplus/blob/main/CHANGES.rst |
Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
The diff LGTM! I would use the "Squash and Merge" button but it is currently disabled by this repo. @bsipocz , should we enable "Squash and Merge"? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Sure 😄 I don’t quite get your “Nitpick” change though: I preserved the number of newlines between the last changelog entry and the next header intentionally 😉 |
Yeah, sorry. Strictly speaking, preserving the existing number of blank lines is more correct, though I do not really care if it is two or one, personally. |
I don't like squash and merge and would not like to use it here, instead prefer to use the release scripts to do changelog consistency and nitpicks prior release, rather than in the PRs. |
Is there anything left to do for me or is this good to go? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed the nitpick and revert commit, and will go ahead with merging. Thanks @flying-sheep!
Fixes #229